search

mostafa272 / Gif-Player

A Joomla plugin for playing and stoping the GIF images.
1 stars 1 forks source link

Enabling plugin breaks modal #3

Open PhilippSPOTTERON opened 6 years ago

PhilippSPOTTERON commented 6 years ago

Hi, another issue is that when the plugin is enabled, a modal box built in our website at www.spotteron.net doesnt work anymore:

(index):133 Uncaught TypeError: a(...).jf_login_modal is not a function at (index):133 at dispatch (jquery-1.11.2.min.js:3) at r.handle (jquery-1.11.2.min.js:3)

The modal is the black login icon on top right. With an unpublished plugin it works normally.

mostafa272 commented 6 years ago

@PhilippSPOTTERON Hi, It should be a conflict in jQuery codes. Open gifplayer.php and in lines 19 and 20 change dollar signs ($) to jQuery. If replacing dollar signs with jQuery was not useful, try to remove line 17 of gifplayer.php. This line calls jquery-1.11.2.min.js. I hope it works for you.

PhilippSPOTTERON commented 6 years ago

Hi, thanks for the reply, i changed one of the two in those lines like that: $script="$(document).ready( function(){ jQuery('.gifplayer').gifplayer({label:'".$label."'});

        });";

but I am not sure what to do with the .$label and $script. - I tried jQuery(label) but that just makes a 500 internal server error. or is it jQueryscript and jQuerylabel?

mostafa272 commented 6 years ago

@PhilippSPOTTERON No, read my previous comment again. Just change $(document) to jQuery(document) and in next line change $('.gifplayer') to jQuery('.gifplayer'). $label is a PHP variable and this problem is related to Javascript. Don't change it.

PhilippSPOTTERON commented 6 years ago

Thanks for your clearification, I am coming from a design background and while good at css and art tools, I am not so experienced in programming from scratch. I changed it according to your instructions but it still breaks the modal login box at www.spotteron.net

code: $script="jQuery(document).ready( function(){ jQuery('.gifplayer').gifplayer({label:'".$label."'});

mostafa272 commented 6 years ago

@PhilippSPOTTERON Do you try to remove line 17 ? code of this line is this:

$document->addScript('https://code.jquery.com/jquery-1.11.2.min.js');

PhilippSPOTTERON commented 6 years ago

Ok, super, that did the trick! Works again now, it seems this created the conflict. Thanks.

mostafa272 commented 6 years ago

@PhilippSPOTTERON not at all, Philip.