search

mostafa272 / Instagram-Fetcher

Show your Instagram recent posts on your joomla website.
4 stars 0 forks source link

Only variables should be assigned by reference #4

Open marcelo-mig opened 5 years ago

marcelo-mig commented 5 years ago

Hi Mustafa,

Thanks for the nice extension, It is running like expected, but I see in the log file a lot of this error:

"Only variables should be assigned by reference in /home/(my_site)/public_html/modules/mod_instagramfetcher/tmpl/default.php on line 8

Can you fix it?

Thanks in advance, Marcelo

Joomla 3.9.6 PHP Version 7.2.18

mostafa272 commented 5 years ago

@marcelo-mig Hi, This error is created in new versions of PHP. I changed my code. Please test it again and let me know it works correctly. https://github.com/mostafa272/Instagram-Fetcher/files/3277806/mod_instagramftecher.zip

marcelo-mig commented 5 years ago

@mostafa272 Hi Mustafa,

That alert is not showing up anymore, but just before I installed the new version the extension was failing to load all images from Instagram.

Installing the upgrade didn´t fix this new issue.

Error messages in the log file: [18-Jun-2019 13:42:12] PHP Notice: Undefined property: stdClass::$data in /xxx/public_html/modules/mod_instagramfetcher/helper.php on line 20 [18-Jun-2019 13:42:12] PHP Notice: Trying to get property 'link' of non-object in /xxx/public_html/modules/mod_instagramfetcher/tmpl/default.php on line 15 [18-Jun-2019 13:42:12] PHP Notice: Trying to get property 'images' of non-object in /xxx/public_html/modules/mod_instagramfetcher/tmpl/default.php on line 15 [18-Jun-2019 13:42:12] PHP Notice: Trying to get property 'standard_resolution' of non-object in /xxx/public_html/modules/mod_instagramfetcher/tmpl/default.php on line 15 [18-Jun-2019 13:42:12] PHP Notice: Trying to get property 'url' of non-object in /xxx/public_html/modules/mod_instagramfetcher/tmpl/default.php on line 15

Can you try to figure out the reason for this error and fix it? Thank you for your attention,

Marcelo

mostafa272 commented 5 years ago

@marcelo-mig Hi again, I changed the code and I hope it works correctly. I'm so busy in these days and I could not test it myself. Please try following file. Make sure you set all parameters correctly. Let me know it works fine. mod_instagramftecher.zip

marcelo-mig commented 5 years ago

@mostafa272 Hi Mostafa,

Unfortunately, the new version didn´t fix the problem. It got even worse. We could see, in the other version, that there were links to Instagram, but these links were failing to work as if the parameters were wrong. The new version doesn´t load anything, except for the title of the module.

The parameters didn´t change since instalation, and the module was working fine,

Coud it be a connection problem related with security issues with Instagram? In URL https://www.instagram.com/developer/ there is an alert about scheduled disabled capabilities.

Att,

Marcelo

mostafa272 commented 5 years ago

@marcelo-mig Hi, can you place a demo link to check the problem?

marcelo-mig commented 5 years ago

Hi Mustafa,

I´ve downloaded the software version available in https://github.com/mostafa272/Instagram-Fetcher/archive/master.zip and installed in a test environment located in http://migbits.com.br/joomla3/.

There you can see Instagram Fetcher and the problems I am writing about.

Error log says: [30-Jun-2019 19:20:42 America/Sao_Paulo] PHP Notice: Undefined property: stdClass::$data in /home/xxx/public_html/joomla3/modules/mod_instagramfetcher/helper.php on line 20 [30-Jun-2019 19:20:42 America/Sao_Paulo] PHP Notice: Trying to get property 'link' of non-object in /home/xxx/public_html/joomla3/modules/mod_instagramfetcher/tmpl/default.php on line 15 [30-Jun-2019 19:20:42 America/Sao_Paulo] PHP Notice: Trying to get property 'images' of non-object in /home/xxx/public_html/joomla3/modules/mod_instagramfetcher/tmpl/default.php on line 15 [30-Jun-2019 19:20:42 America/Sao_Paulo] PHP Notice: Trying to get property 'standard_resolution' of non-object in /home/xxx/public_html/joomla3/modules/mod_instagramfetcher/tmpl/default.php on line 15 [30-Jun-2019 19:20:42 America/Sao_Paulo] PHP Notice: Trying to get property 'url' of non-object in /home/xxx/public_html/joomla3/modules/mod_instagramfetcher/tmpl/default.php on line 15

marcelo-mig commented 5 years ago

Hi Mustafa again,

As a test, I went through the proccess of getting the access token in https://elfsight.com/service/get-instagram-access-token/, and, for my surprise, the code was different from the one I was using, with the same Instagram user.

I pasted it on the appropriate field in Instagram Fetcher and now it got back to life.