search

mostafab / neg5.main

Quizbowl tournament management system based in the cloud
Other
15 stars 12 forks source link

Don't restrict access to scoresheets export for non-collaborators #73

Open hftf opened 7 years ago

hftf commented 7 years ago

If the point of this software is to advance the state of quizbowl statkeeping, what is the purpose of restricting the current qbj and scoresheets API endpoints to tournament collaborators only?

https://github.com/mostafab/neg5/blob/587efdf394377cc26422b77e437126295eecc53c/app/build/routes/api/stats.js#L94-L103

gregorygauthier commented 7 years ago

I see an issue with notes fields becoming publicly available, as moderators/scorekeepers may (unwittingly) use them for private discussion or, worse, details of uncleared questions (if there's a protest). Also, one should consider the potential impacts on question security if conversion statistics for particular tossups and bonuses are made publicly available to players who may play the set later.

jonahgreenthal commented 7 years ago

I agree. At best, this should be up to the tournament director.

However, for NAQT's purposes it would be nice if QBJ export without scoresheet details were available to us :-)

mostafab commented 7 years ago

I would be willing to open up the QBJ route to non-collaborators, since NAQT needs that information and it makes it easy to retrieve the information without contacting the tournament director first. There is the issue with notes, though.

The scoresheet route, however, should definitely stay locked for now due to reasons stated above.

jonahgreenthal commented 7 years ago

Okay, so how does someone who's not an authorized user on the tournament export a QBJ file from the :3000 version?