mostafaelaraby / wavegan-pytorch

Pytorch Implementation of wavegan model to generate audio
https://arxiv.org/abs/1802.04208
Apache License 2.0
162 stars 43 forks source link

WavGAN paper recommends against upsampling. #10

Open nickwharrington44 opened 1 year ago

nickwharrington44 commented 1 year ago

Thanks very much for making this repo!

Quick comment is that, as I understand it, the WavGAN paper actually does not recommend nearest neighbor upsampling, and instead better results were obtained by the standard ConvTranspose approach. However, in model.py, the class "Transpose1dLayer" has a comment saying that upsampling IS recommended and the class "WaveGANGenerator" has upsampling enabled by default.