mostafamaklad / laravel-permission-mongodb

Associate users with roles and permissions using Laravel and MongoDB
https://maklad.dev
MIT License
112 stars 66 forks source link

Defer registering permissions on the Gate instance until it's resolved #104

Closed rasmusdencker closed 4 years ago

rasmusdencker commented 4 years ago

Description, motivation and context

The package provisioned the Gate instance upon each boot, coincidentally destroying all artisan commands if the app did not have a working database connection.

How has this been tested?

Since this is a performance refactor, I haven't created new tests.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d75bbd58a6bde40e527247d7efaf96bcde66edf6 on rasmusdencker:master into bec3d0e286e734c99e5c9bcdf1ec043f9b60da40 on mostafamaklad:master.

mostafamaklad commented 4 years ago

Thanks for your pull request and I am sorry for my late response