The package provisioned the Gate instance upon each boot, coincidentally destroying all artisan commands if the app did not have a working database connection.
How has this been tested?
Since this is a performance refactor, I haven't created new tests.
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
Go over all the following points, and put an x in all the boxes that apply.
Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
Coverage remained the same at 100.0% when pulling d75bbd58a6bde40e527247d7efaf96bcde66edf6 on rasmusdencker:master into bec3d0e286e734c99e5c9bcdf1ec043f9b60da40 on mostafamaklad:master.
Description, motivation and context
The package provisioned the
Gate
instance upon each boot, coincidentally destroying allartisan
commands if the app did not have a working database connection.How has this been tested?
Since this is a performance refactor, I haven't created new tests.
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!