search

mostertb / phpsa-2017-profiles

Humorous educational project build by the PHP South Africa 2017 conference attendees
MIT License
0 stars 26 forks source link

Fixed the styles and scripts reference link #25

Closed MisterBrownRSA closed 7 years ago

MisterBrownRSA commented 7 years ago

fuuuuuuuuu forgetting the leading slashes.

mostertb commented 7 years ago

Hi @MisterBrownRSA

I see you've made two changes in this PR. Im happy to merge the change to views/profiles/show.twig but the change to the leading slashes is not going to work in the production environment.

The code is deployed to a cpanel account with the repo checked out under public_html (i.e. the web root). This means that the CSS is under http://www.phpsa2017profiles.co.za/public/css/ but specifying the src attribute to have a leading slash is going to make the browser look in http://www.phpsa2017profiles.co.za/css/

MisterBrownRSA commented 7 years ago

@mostertb good point. Updated to reflect the better absolute path. Hope this finds you well :)

mostertb commented 7 years ago

Many thanks 👍