search

mostlyserious / riak-js

Riak client for Javascript
http://riak-js.org
476 stars 102 forks source link

Riak 2.0? #221

Closed MrBokeh closed 9 years ago

MrBokeh commented 10 years ago

Hi there, are you going to support riak 2.0?

sideshowcoder commented 10 years ago

I got started on this some time ago see #199 the basics were pretty straight forward, wonder if this is still the case.

gigonaut commented 10 years ago

looking through the tests as they exist today, and running them against Riak 2.0 I am getting 8 failures and from a quick glance most of them have to do with things that were changed in 2.0 (search and whatnot). Going to be working on this to see if I can get resolution to the tests that I can get fixed and see what other coverage is missing.

Neamar commented 10 years ago

Awesome! Keep us in the loop we'd like to merge that

mogadanez commented 10 years ago

https://github.com/mostlyserious/riak-js/pull/225 Here is pull request with 2.0 support Using it in production successful It was incorporate #199 and add more fixes

gigonaut commented 10 years ago

I pulled the #225 pr into a branch (metacomms-2.0) on this repo that came from the current state of our master.

I am still getting failed tests (but it appears as though I am getting failed tests on that branch directly as well against 2.0). I should be able to look into it a bit more this evening, but if someone wants to jump in in the mean time, I will not be offended.

gigonaut commented 10 years ago

Ok, after that, all tests except protobuff tests pass. Http client should be good to go.

Quentin01 commented 10 years ago

With the latest fixes on master I used riakpbc 2.1 and this lib support Riak 2.0 protobuff. It's weird if all tests except protobuff tests pass.

mogadanez commented 10 years ago

Yep, forgot update node modules. After update riakpbc, generic protobuff tests passed. now failed only:

  ✖ 4 of 92 tests failed:

  1) protocol-buffers-mapreduce-client Map/Reduce:
     TypeError: Cannot read property 'should' of undefined
      at ProtocolBuffersMapReduceMeta.callback (/home/apopov/projects/riak-js/test/protocol-buffers-mapreduce-test.js:73:16)
      at callback (/home/apopov/projects/riak-js/lib/protocol-buffers-client.js:103:10)
      at Object.cb [as callback] (/home/apopov/projects/riak-js/node_modules/riakpbc/index.js:193:9)
      at /home/apopov/projects/riak-js/node_modules/riakpbc/index.js:52:25
      at process._tickCallback (node.js:419:13)

  2) protocol-buffers-search-client Finds documents via search:
     TypeError: Cannot read property 'docs' of undefined
      at ProtocolBuffersSearchMeta.callback (/home/apopov/projects/riak-js/test/protocol-buffers-search-test.js:25:11)
      at Object.callback (/home/apopov/projects/riak-js/lib/protocol-buffers-client.js:83:19)
      at /home/apopov/projects/riak-js/node_modules/riakpbc/index.js:52:25
      at process._tickCallback (node.js:419:13)

  3) http-client-solr-tests creates an index:
     AssertionError: expected { [Error: <HTML><HEAD><TITLE>404 Not Found</TITLE></HEAD><BODY><H1>Not Found</H1>The requested document was not found on this server.<P><HR><ADDRESS>mochiweb+webmachine web server</ADDRESS></BODY></HTML>]
  message: '<HTML><HEAD><TITLE>404 Not Found</TITLE></HEAD><BODY><H1>Not Found</H1>The requested document was not found on this server.<P><HR><ADDRESS>mochiweb+webmachine web server</ADDRESS></BODY></HTML>',
  statusCode: 404,
  notFound: true } to not exist
      at /home/apopov/projects/riak-js/test/2.0-specific/http-yokozuna-client-test.js:37:18
      at IncomingMessage.<anonymous> (/home/apopov/projects/riak-js/lib/http-request.js:146:7)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:929:16
      at process._tickCallback (node.js:419:13)

  4) http-client-solr-tests Searching via Solr interface:
     AssertionError: expected { [Error: <HTML><HEAD><TITLE>404 Not Found</TITLE></HEAD><BODY><H1>Not Found</H1>The requested document was not found on this server.<P><HR><ADDRESS>mochiweb+webmachine web server</ADDRESS></BODY></HTML>]
  message: '<HTML><HEAD><TITLE>404 Not Found</TITLE></HEAD><BODY><H1>Not Found</H1>The requested document was not found on this server.<P><HR><ADDRESS>mochiweb+webmachine web server</ADDRESS></BODY></HTML>',
  statusCode: 404,
  notFound: true } to not exist
      at /home/apopov/projects/riak-js/test/2.0-specific/http-yokozuna-client-test.js:62:18
      at meta.callback (/home/apopov/projects/riak-js/lib/http-yokozuna-client.js:90:14)
      at IncomingMessage.<anonymous> (/home/apopov/projects/riak-js/lib/http-request.js:146:7)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:929:16
      at process._tickCallback (node.js:419:13)
mogadanez commented 10 years ago

Fixed the rest.

 91 tests complete (47 seconds)
joques commented 9 years ago

Hi all, I would like to know if riak 2.0 transition is complete. I would like to move the db in my app from riak 1.4 to 2.0. Where can I find the corresponding documentation if the new version is ready thanks José

Quentin01 commented 9 years ago

Hi, Sorry but I am waiting for https://github.com/mostlyserious/riak-js/pull/225 and I don't have enough time at the moment to complete this PR.

gigonaut commented 9 years ago

If I can get time to do this later in the week I will, I believe the only reason pr #225 is held up is because of a couple of async issues.

Kinetic915 commented 9 years ago

Hello all, Wondering if there is any update on 2.0? Thanks!

Quentin01 commented 9 years ago

@Kinetic915 See https://github.com/mostlyserious/riak-js/pull/225