Support for Riak 2.0. Ability to use special indices $bucket, $key. Ability to provide max_results and continuation in db.query and get continuation back.

mostlyserious / riak-js

Riak client for Javascript

http://riak-js.org

476 stars 102 forks source link

Support for Riak 2.0. Ability to use special indices $bucket, $key. Ability to provide max_results and continuation in db.query and get continuation back. #225

Closed mogadanez closed 9 years ago

Neamar commented 10 years ago

Hi,

Can you merge master back into your branch?

Hopefully the CI will work now and give us visibility on merge status.

mogadanez commented 10 years ago

Merged, locally all test except protobuf is passed. travis has strange issues with riak connection, trying to research

Quentin01 commented 10 years ago

Your build don't pass with Travis CI

Quentin01 commented 10 years ago

Oops, I haven't seen your previous comment. You may need to wait Riak for the service to start.

mogadanez commented 10 years ago

It passed now. Actually some tests is very unstable and failing time to time even locally due some timings But problems is in test not library.

Quentin01 commented 10 years ago

It's dirty to use many setTimeout. Can you use another solution or look at why it is mandatory to use setTimeout?

PS : Maybe a riak-admin wait-for-service?

mogadanez commented 10 years ago

Its come to our repository from https://github.com/sideshowcoder/riak-js

SetTimeouts is really hack. But for now I don't know better alternative. Inside test it is not wait for service. But wait for index propagation, and data indexed. Since it is async operation https://github.com/metacommunications/riak-js/commit/0ac9d6c1bec1ce18592df16ce749228467451a67 http://lists.basho.com/pipermail/riak-users_lists.basho.com/2014-November/016198.html

Probably it can be extracted from test to setup required test schema in install_riak.sh script.

Quentin01 commented 10 years ago

OK, so can you make a more proper code by using async module or another async library? https://github.com/mostlyserious/riak-js/pull/225#discussion-diff-20995748

mogadanez commented 10 years ago

Yes, but probably only on weekend

On Thu, Nov 27, 2014 at 6:22 PM, Quentin Buathier notifications@github.com wrote:

OK, so can you make a more proper code by using async module or another async library ?

— Reply to this email directly or view it on GitHub https://github.com/mostlyserious/riak-js/pull/225#issuecomment-64802440.

Quentin01 commented 10 years ago

Any news for the updating of the tests ? Or for that comment : https://github.com/mostlyserious/riak-js/pull/225#discussion-diff-20995748 ?

mogadanez commented 9 years ago

Sorry for delay, test updated and test client now used.

mogadanez commented 9 years ago

ping

mogadanez commented 9 years ago

BTW, official node library is in active development https://github.com/basho/riak-nodejs-client probably good alternative

zowers commented 9 years ago

any eta on when somebody can merge this?

Quentin01 commented 9 years ago

This PR looks good. So, I merge it now. But I think we must do some refactor later on some things. And sorry for the long time without answers :S