search

mosuka / blast

Blast is a full text search and indexing server, written in Go, built on top of Bleve.
Apache License 2.0
1.08k stars 76 forks source link

Make the API easier to work with #47

Open ghost opened 5 years ago

ghost commented 5 years ago

Have you used https://github.com/googleapis/gnostic ?

It would make lots of the code you wrote redundant and make it much easier to extend. Also much less bugs.

To explain. From GPRC it can gen all of your openAPI based REST ! OpenAPI is the main way to do REST. Swagger is dead.

It can also do the opposite amazingly. OPENAPI to GRPC. But i think using GRPC as the source of truth is best for Blast.

Have a think about it. I can help if your interested...

mosuka commented 5 years ago

This may also take time, but consider the implementation. I will keep you waiting, but please give me time.

ghost commented 5 years ago

Yes it's just an idea. I use it for many projects with grpc where I also want to expose a rest interface. The nice thing of course is the web GUI also.

maxn0d3x commented 5 years ago

Yes it's just an idea. I use it for many projects with grpc where I also want to expose a rest interface. The nice thing of course is the web GUI also.

What about grpc-web ?? I need let users access directly from browser.. grpc-web required in that case. Rest api is still dominant. Grpc is not the future yet for the web but microservice inside server. Http/2 with Rest API is quite general approach still in the web world.