mosure / bevy_gaussian_splatting

bevy gaussian splatting render pipeline plugin
https://mosure.github.io/bevy_gaussian_splatting?gaussian_count=1000
MIT License
130 stars 9 forks source link

overloaded system, move to resource setup system #62

Open github-actions[bot] opened 7 months ago

github-actions[bot] commented 7 months ago

https://github.com/mosure/bevy_gaussian_splatting/blob/507a28dda771518415d762f85db7607ea60bfbe8/src/render/mod.rs#L759


    asset_server: Res<AssetServer>,
    gaussian_cloud_res: Res<RenderAssets<GaussianCloud>>,
    sorted_entries_res: Res<RenderAssets<SortedEntries>>,

    #[cfg(feature = "buffer_storage")]
    gaussian_clouds: Query<(
        Entity,
        &Handle<GaussianCloud>,
        &Handle<SortedEntries>,
    )>,
    #[cfg(feature = "buffer_texture")]
    gaussian_clouds: Query<(
        Entity,
        &Handle<GaussianCloud>,
        &Handle<SortedEntries>,
        &texture::GpuTextureBuffers,
    )>,

    #[cfg(feature = "buffer_texture")]
    gpu_images: Res<RenderAssets<Image>>,
) {
    let Some(model) = gaussian_uniforms.buffer() else {
        return;
    };

    // TODO: overloaded system, move to resource setup system
    groups.base_bind_group = Some(render_device.create_bind_group(
        "gaussian_uniform_bind_group",
        &gaussian_cloud_pipeline.gaussian_uniform_layout,