motatoes / MAdetection

1 stars 2 forks source link

missing ria.util #1

Closed maybefreedom closed 7 years ago

maybefreedom commented 7 years ago

Hi! great project! I've been following your code but I can't find the cell2mask and mask2cell functions. Can you add them?

motatoes commented 7 years ago

Hey thanks for stopping by, yeah I'll do this as soon as I get a chance later today :)

maybefreedom commented 7 years ago

okay thank you !!

motatoes commented 7 years ago

@maybefreedom can you please paste the exact MATLAB error that shows up when you attempt to run in a comment. I wanna know the line numbers where the imports are msising. Thanks

maybefreedom commented 7 years ago

Undefined variable "ria" or class "ria.util.mask2cell".

Error in Candidates/setFromBinaryImage (line 17) self.cellArray = mask2cell(binaryImage);

Error in detectFlemingCandidates (line 37) candidates.setFromBinaryImage( gaussImage >= (tau*5) );

In Candidates.m there are two functions: function setFromBinaryImage(self, binaryImage, varargin) self.binaryImage = binaryImage; self.cellArray = ria.util.mask2cell(binaryImage); end

    function setFromCellArray(self, cellArray, imageSize, varargin)
        self.cellArray = cellArray;
        self.binaryImage = ria.util.cell2mask(cellArray, imageSize);
    end

where ria.util.cell2mask/mask2cell don't exist anywhere else.

maybefreedom commented 7 years ago

Have you found it? Also can you explain why you used mask2cell for the tresholding?

motatoes commented 7 years ago

Hey I've included the missing functions in 6e78274ac59fb7b37d9aa3a3e97825bc204eb6f0

Please pull the code and then try running again to see if it works for you? Also we use a mask in order to extract only the field of view of the retina and exclude the black background. Since false positives can be detected around the borders of the retina field of view.

maybefreedom commented 7 years ago

yes it's working now! thank you