search

motefly / DeepGBM

SIGKDD'2019: DeepGBM: A Deep Learning Framework Distilled by GBDT for Online Prediction Tasks
647 stars 135 forks source link

max_ntree_per_split is 0 #18

Open meditations opened 4 years ago

meditations commented 4 years ago

It seems the max_ntree_per_split is not properly initiated, and it's always 0.

Traceback (most recent call last): File "main.py", line 102, in main() File "main.py", line 94, in main train_DEEPGBM(args, num_data, cate_data, plot_title, key="") File "/Users/binrong/Desktop/Code/DeepGBM/experiments/train_models.py", line 165, in train_DEEPGBM emb_model = EmbeddingModel(n_models, max_ntree_per_split, args.embsize, args.maxleaf+1, n_output, group_average, task=args.task).to(device) File "/Users/binrong/Desktop/Code/DeepGBM/experiments/models/components.py", line 230, in init stdv = math.sqrt(1.0 /(max_ntree_per_split)) ZeroDivisionError: float division by zero

motefly commented 4 years ago

Thanks, there may be some corner cases that make it an error, please consider fixing it in your code.