mothership-ec / cog-mothership-ecommerce

Mothership E-Commerce
Other
2 stars 1 forks source link

Product page links #250

Closed kuiche closed 9 years ago

kuiche commented 9 years ago

This adds a tab to the product edit screen displaying product pages for easier navigation.

Requires https://github.com/mothership-ec/cog-mothership-commerce/pull/453.

thomasjthomasj commented 9 years ago

A logic exception gets thrown (Service 'product.page_type.listing' must be defined within the installation) when trying to add a new page on existing installations. I think this exception must have been included with the product upload stuff but that side of stuff is inaccessible. I think ideally there will be some kind of default setup for this service, and less ideally, you won't have access to page creation from this tab without this service being set up. If we go for that option then obviously we can add a service to the base installation but it would be nice if it could work straight off the bat as soon as someone upgrades their MS installation

kuiche commented 9 years ago

It's not using that listing class anywhere (it creates them under whatever parent you give) so it should be possible to remove that requirement when just creating single pages.

thomasjthomasj commented 9 years ago

Okay well we need to make it possible to do that without that exception being thrown then i guess