search

mothership-ec / cog-mothership-file-manager

Mothership File Manager Cogule
Other
1 stars 1 forks source link

File deletion #1

Closed EwanValentine closed 11 years ago

jamesmoss commented 11 years ago

You've committed the vendor folder here, this shouldn't be tracked in git.

Also make sure you merge master into your branch before creating a pull request to ensure we can merge it in gitlab.

jamesmoss commented 11 years ago

There's quite a few docblock formatting issues here. The layout / format isn't arbritary and follows a set pattern. I'd recommend reading this tutorial to get a better idea of how they work: http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_phpDocumentor.howto.pkg.html

jamesmoss commented 11 years ago

Also make sure you merge in master so the button down there :arrow_down: turns green.

dannyhannah commented 11 years ago

Whats going on with this one? There is no description of what this does?! There is already a Delete.php class in the File manager so I need to know what this does, also it doesn't look like any of the QA points have been fixed

joeholdcroft commented 11 years ago

@dannyhannah good point. No idea how this ended up happening.. but if we already have a working delete decorator and functionality then I guess we can close this.