search

mothership-ec / cog-mothership-file-manager

Mothership File Manager Cogule
Other
1 stars 1 forks source link

All assets are coming up as images #23

Closed richmccartney closed 11 years ago

richmccartney commented 11 years ago

When looking at the details page for a file, I've noticed if I have uploaded a .PDF or a .MOV file it will still be wrapped in an tag and reference the file. Thats wrong.

Can we get that changed so I can put in a placeholder image (when assets work) for different file types which are not images.

lsjroberts commented 11 years ago

I've added a check in the view here 2dae48911e8e84632deb8b4e16547b42148e1a2f, though we will need to decide how to display the placeholder icons.

dannyhannah commented 11 years ago

Can we not just using the file extension for now as the image name? mov.png, pdf.png etc?

lsjroberts commented 11 years ago

That's the idea, we just need some icons making.

dannyhannah commented 11 years ago

Oh right, pull your finger out then @richmccartney

aislingbrock commented 11 years ago

Yeah, do images exist for this already @richmccartney? Your issue kind of makes it sound like they do and you were just waiting for assets to work?

aislingbrock commented 11 years ago

In relation to this, "alt text" isn't really relevant for some file types, should we exclude it in those cases?

aislingbrock commented 11 years ago

I have added a document icon (just used something from FontAwesome since everything else is from there. Probably fine for now since I think things are mainly images or pdfs. Can probably look at getting into more specific file types at a later date.