mothership-ec / cog-mothership-file-manager

Mothership File Manager Cogule
Other
1 stars 1 forks source link

Select box filtering #32

Closed richmccartney closed 10 years ago

richmccartney commented 11 years ago

In the sidebar we have two select boxes which are ment to filter the assets we have. The sort by should be set i.e name, type(image, text file, video), file size but the filter by should be types of files i.e .jpg, .png.

When filtering we need a key to show above the images to state what type of filtering has happened.

lsjroberts commented 11 years ago

Would a client care about filtering between .jpg and .png? Would they not just want to filter by image, video, document, other?

lsjroberts commented 11 years ago

I've added filtering and sorting logic here 4e09f562f3008f0124a692da1e4d19fccb9d06ba (probably shouldn't have done this on master though...)

Will require some js to get the form to submit or something.

joeholdcroft commented 11 years ago

@richmccartney I don't agree RE filtering. Type is not helpful when ordering (because it will always show documents first due to alphabet right?). Type is much more useful as a filter.

Agreed @lsjroberts that the client likely won't need to go as granular as the specific file type, certainly for version 1.

RE ordering, things like name, uploaded date etc make more sense.

All of this said, the entire file manager module is sort of additional so we needn't be creating ourselves unnecessary work for v1: too much other stuff to do.

lsjroberts commented 11 years ago

@joeholdcroft Removed sorting by file type 5f6a9fc03526c6c99833a06560367690b0e00276

joeholdcroft commented 11 years ago

Note this form was hidden as the functionality was not yet implemented.

kuiche commented 10 years ago

Closing this as is in relation to a future feature https://github.com/messagedigital/cog-mothership-file-manager/issues/24.

kuiche commented 10 years ago

Closing as feature was removed, will be reimplemented in https://github.com/messagedigital/cog-mothership-file-manager/issues/24.