search

mothership-ec / cog-mothership-file-manager

Mothership File Manager Cogule
Other
1 stars 1 forks source link

File tag lazy loading #72

Closed kuiche closed 10 years ago

kuiche commented 10 years ago

What does this do?

Lazy Loading for file tags - breaks BC (getters & setters for tags used, instead of public member)!

How should this be manually tested?

Check pages where files are handled, ensure nothing breaks! Check file objects before and after calling getTags(), make sure this uses the FileProxy class, try updating tags etc.

Related PRs / Issues / Resources?

Relies on https://github.com/messagedigital/cog/pull/386

Anything else to add? (Screenshots, background context, etc)

Should reduce the number of queries on pages where files are loaded. See file manager.

irisSchaffer commented 10 years ago

This might be a stupid question... But why do we not use the new lazy loading strategy here (or only half of it)?