search

mothership-ec / cog-user

User Cogule
Other
0 stars 1 forks source link

Code duplication on "current user" service definition #2

Closed joeholdcroft closed 11 years ago

joeholdcroft commented 11 years ago

There is some duplicated code that is responsible for setting the service definition for the currently logged in user user.current. It's both in the services bootstrap Bootstrap\Services and the Controller\Authentication::loginAction controller.

To remedy this we could create class that is responsible for handling the user's session and the currently logged in user service definition. This could also be extended in future to give administrators the functionality to log users out (invalidating their session) and so on.

joeholdcroft commented 11 years ago

Closing because I managed to remove the code duplication anyway. Silly me.