search

mothership-ec / cog

Cog
Other
2 stars 3 forks source link

Update Bcrypt.php #418

Closed sarciszewski closed 9 years ago

sarciszewski commented 9 years ago

Incorporate some of the changes from https://github.com/ircmaxell/password_compat

thomasjthomasj commented 9 years ago

Hi Scott

Welcome to Mothership, and that's a lot for these contributions. I've taken a look at this one and aside from these minor code-style comments it all looks good to me

Make these changes and I'm happy to merge it :)

sarciszewski commented 9 years ago

Sure thing. That was copypasta from password_compat. I've pushed another commit to the branch.

kuiche commented 9 years ago

Another minor code comment - the stuff you've copied uses spaces. We prefer tabs, more importantly the file is now a mixture of spaces and tabs for indentation.

thomasjthomasj commented 9 years ago

Nice catch Sam

As a side note, we should probably publish a page on Mothership code guidelines on the wiki

sarciszewski commented 9 years ago

Crap, I'm using Github's online editor. I don't have a tab-friendly IDE on this device (I use PSR-2 for everything where I can). It might be quicker if you guys recreate the changes separately in a manner consistent with your coding style.

thomasjthomasj commented 9 years ago

No worries Scott, will do

Thanks again for the contribution :)