mothership-ec / cog

Cog
Other
2 stars 3 forks source link

SQLAdapter in Pagination component is a bit flaky #435

Closed thomasjthomasj closed 9 years ago

thomasjthomasj commented 9 years ago

On one Mothership site, when using the SQLAdapter for pagination in conjunction with the page loader, it would return a bunch of rows with a value of 1, and the number of rows seemed to match the number of pages it needed. The SQLAdapter was amended to accommodate this (https://github.com/mothership-ec/cog/pull/427), but it appears that this has broken pagination on pre-existing Mothership sites, so this how now been reverted (https://github.com/mothership-ec/cog/pull/434), but the mystery of the broken sql pagination remains unsolved