Use ABSOLUTE_URL constant on URL generation, closes #345

mothership-ec / cog

Cog

Other

2 stars 3 forks source link

Use ABSOLUTE_URL constant on URL generation, closes #345 #470

Closed thomasjthomasj closed 9 years ago

thomasjthomasj commented 9 years ago

This PR resolves issue #345.

To test this I checked that the following worked:

Links on front end
Links in admin panel
Links sent to flash messages (e.g. when deleting a page or change a flash message to one from a deleted page)
Submitting forms with an action set

kuiche commented 9 years ago

Is this actually a bug? They both work equally fine. I was looking at that issue yesterday and considered straight up just closing it.

thomasjthomasj commented 9 years ago

Well my feeling is that while they both work the ABSOLUTE_URL one at least seems more semantically correct at the very least

kuiche commented 9 years ago

I don't think it's any more semantically correct. Absolute paths are for site internal links. The links generated the site are for the site so straight up absolute path makes perfect sense. I don't really think it matters either way.

kuiche commented 9 years ago

It also makes the links generated inconsistent with Slug links i.e. any CMS page link.