search

motia / quasar-app-extension-onesignal

Adds onesignal push notifications to quasar framework apps.
MIT License
5 stars 5 forks source link

Problem with Object.assign #3

Closed Deployvix closed 4 years ago

Deployvix commented 4 years ago

Hi, I'd like to comment a change at the init method 1

As you might see, after you make the assignment, properties like the notifyButton and the welcomeNotification will be overwritten by yours default object. Could you please just change the order of the assignment?

E.g:

Object.assign( { ...default_propoerties }, initConfig )

motia commented 4 years ago

Thanks for the heads up. It was implemented in 0.2.3.