search

motiko / sfdc-debug-logs

Browser extension for Salesforce logs management
http://motiko.github.io/sfdc-debug-logs/
MIT License
31 stars 12 forks source link

Disable hotkeys when typing in a text area #7

Closed e02d96ec16 closed 6 years ago

e02d96ec16 commented 6 years ago

Discovered a new way to delete all my logs: by trying to write a feedback message! 😬

motiko commented 6 years ago

Thanks, mate. Sorry it happened to you. Clearly remember fixing it before 😞 Was it easy for you to find the fix? I should add a build guide to the README..

e02d96ec16 commented 6 years ago

Found it by chance, so not as terrible a trace to debug as it would have been if they just magically disappeared.

I was paranoid about where Feedback was sending the messages. As soon as I started typing, I saw a flurry of network traffic, all about my lovely logs being scrapped. From there on it was a matter of finding the key event listener with the Inspector, which I have no real idea how to do, but eventually got to it through Ctrl+F -ing the source more than anything.

I just edited this in GH; don't know enough for building stuff anyway.

UX-wise this is terrible I suppose. I don't recall even getting any feedback about the action.

motiko commented 6 years ago

I see, sorry again. Will update new version with the fix soon.

e02d96ec16 commented 6 years ago

No worries! I haven't lost any real logs. I was actually just going through my extensions, and had just discovered the new debug page. 😅