Closed zheningy closed 1 year ago
@patk-motional Please check if this is a bug, thanks.
Hi @zheningy,
The first iteration is the 0th step. If the simulation has 100 iterations then there should be the 0th step up until the 99 step. Hence, the equality in the condition.
Describe the bug
In the below function in StepSimulationTimeController. If the index is in range(self.number_of_iterations()). It seems the reach_end condition should be self.current_iteration_index > self.number_of_iterations() - 1. Current implementation would lead to simulation always ending 1 step early.