motional / nuplan-devkit

The devkit of the nuPlan dataset.
https://www.nuplan.org
Other
636 stars 126 forks source link

Confuse about objective. #352

Open cdefg opened 10 months ago

cdefg commented 10 months ago

Not actually a bug. I found the code in

https://github.com/motional/nuplan-devkit/blob/master/nuplan/planning/training/modeling/objectives/imitation_objective.py are using definition like:

...
def compute(self, predictions: FeaturesType, targets: TargetsType, scenarios: ScenarioListType) -> torch.Tensor:
...

But predictions should be also be TargetsType.

And this curcumstances also occur in other files

https://github.com/motional/nuplan-devkit/blob/master/nuplan/planning/training/modeling/objectives/abstract_objective.py

Not a big problem, but hope you fix it.