SVG elements (like motion.text) now update when given a MotionValue as children, matching HTML element behavior

motiondivision / motion

A modern animation library for React and JavaScript

https://motion.dev

MIT License

25.66k stars 843 forks source link

SVG elements (like motion.text) now update when given a MotionValue as children, matching HTML element behavior #2841

Open simonkarman opened 4 weeks ago

simonkarman commented 4 weeks ago

Fixes the issue as described in: https://github.com/framer/motion/issues/2578

Feature was introduced in: https://github.com/framer/motion/pull/1877

Changelog:

SVG elements (like motion.text) now update when given a MotionValue as children, matching HTML element behavior.

simonkarman commented 4 weeks ago

@mattgperry The issue is now fixed. I'm happy to provide additional testing or troubleshooting if needed before merging.

Quick question about #1877: Was the decision intentional to implement handleChildMotionValue in HTMLVisualElement rather than DOMVisualElement?

simonkarman commented 2 weeks ago

Hi @mattgperry, what is the process of getting this PR merged? The pipeline succeeds and there are no conflicts with the main branch. Let me know if you are able to review and approve this. Or let me know if there is someone else I should reach out to. Thanks!