search

motioneye-project / motioneye

A web frontend for the motion daemon.
GNU General Public License v3.0
3.99k stars 655 forks source link

motioneye_init: stop and disable conflicting motion.service #2980

Closed MichaIng closed 6 months ago

MichaIng commented 6 months ago

The motion package installs a motion systemd service, which can block camera devices and hence conflict with the motionEye-controlled motion processes.

We hence need to assure that this service is stopped and disabled, before we can start and enable our motioneye.service.

See https://github.com/motioneye-project/motioneye/issues/2810#issuecomment-2102835451, #2816 and other cases.

MichaIng commented 6 months ago

If someone is able to identify the issue with the test_python test, that would be great. See the commit message where I ignore their outcome. The logs are of course still there, even when the result is green. I guess the true error is to be found in the mypy test before the pytest failure, about incompatible variable types in the test classes. In any case, it is an issue with the test itself, not with the code it tests.

zagrim commented 6 months ago

I wonder if the test failure is related to this: https://github.com/tornadoweb/tornado/pull/3374

At least downgrading pytest to 8.1.2 as mentioned here seems to fix the issue.

MichaIng commented 6 months ago

Great find, yes that will be it. I subscribed to the PR and will un-ignore the tests, once it was merged and released.