search

motioneye-project / motioneye

A web frontend for the motion daemon.
GNU General Public License v3.0
3.99k stars 655 forks source link

Add Message-ID to emails. #3028

Closed donlorenzo closed 3 months ago

donlorenzo commented 4 months ago

RFC-2822 specifies that every email SHOULD have a Message-ID field. Some mail servers reject emails that do not have a Message-ID. The eMails sent out by motioneye do not have a Message-ID. This PR adds a Message-ID to the emails sent out by motioneye.

zagrim commented 3 months ago

I could also change the base branch of this PR but maybe it's better if you @donlorenzo check first that your change doesn't break if you rebase it on the current dev branch :sweat_smile: (there seem to be no changes to sendmail.py though between the branches)

donlorenzo commented 3 months ago

I withdraw this PR in favor of https://github.com/motioneye-project/motioneye/pull/3030 targeting the dev branch.

MichaIng commented 3 months ago

The base branch can be changed with the edit button at the top of the PR, and the a rebase onto the base branch can be done at the bottom of the page. No need to reopen a new PR.