motis-project / motis

Intermodal Mobility Information System
https://motis-project.de
MIT License
210 stars 47 forks source link

Somewhat weird routing results around Riga train station #544

Closed jbruechert closed 1 month ago

jbruechert commented 1 month ago

Screenshot_20240914-183613_KDE Itinerary

Screenshot_20240914-185542_KDE Itinerary

Screenshot_20240914-185551_KDE Itinerary

The results should be reproducible on routing.spline.de.

The feeds for Lithuania, Latvia and flixbus europe from https://transitous.org/sources/ should be enough for reproducing it locally.

felixguendling commented 1 month ago

Do you have the JSON response with the stations IDs? Looks like the first osr foot routing didn't find a connection directly to the Riga Bus Station and since we disabled combining osr footpaths with timetable footpaths, there's no other option than to do a loop. One option would be to enable timetable footpaths at the after (or before, at the destination) osr footpaths - but this can lead to quite long combined osr + timetable footpaths (total length = maximum osr footpath duration given in the query + maximum footpath length in the timetable). This is also something an API user would probably not expect.

jbruechert commented 1 month ago

Here is the JSON response response.json

felixguendling commented 1 month ago

My guess is that this was a station start (no coordinates) and for this case, the use_start_footpaths option was off. I changed this in v0.12.14.

jbruechert commented 1 month ago

Makes sense, it was a station start.

jbruechert commented 1 month ago

This is fixed now, thanks!