Prometheus Support

[italolelis]

We need to add Prometheus Support, not as a plugin but as part of the core architecture of Janus. Ideally, we should have a way to choose which instrumentation we want to use (statsd, prometheus, etc). This means we have to encapsulate our current statsd implementation into something that can be replaced by other implementations.

• Janus should, of course, expose the metrics endpoint for Prometheus.
• All the metrics that we have today should also be in Prometheus or whatever other implementation we have, the keys could be different, but ideally should be as similar as possible.

[rafaeljesus]

We can start https://github.com/hellofresh/stats-go was just merged over this week

[DineshReddyK]

Latest stats-go is already supporting "prometheus" as the backend. when I try to use the latest stats-go with "janus" compilation issues are observed.

Is there any plan to support stats-go 1.0.0 with janus ?

pkg/proxy/reverse_proxy.go:109:63: cannot use bucket.MetricOperation literal (type bucket.MetricOperation) as type *bucket.MetricOperation in argument to statsClient.TrackMetric
pkg/proxy/reverse_proxy.go:109:67: cannot use req.Host (type string) as type sync.Mutex in field value
pkg/proxy/reverse_proxy.go:109:67: too few values in struct initializer

[adlecluse]

Latest stats-go is already supporting "prometheus" as the backend. when I try to use the latest stats-go with "janus" compilation issues are observed.

Is there any plan to support stats-go 1.0.0 with janus ?

pkg/proxy/reverse_proxy.go:109:63: cannot use bucket.MetricOperation literal (type bucket.MetricOperation) as type *bucket.MetricOperation in argument to statsClient.TrackMetric
pkg/proxy/reverse_proxy.go:109:67: cannot use req.Host (type string) as type sync.Mutex in field value
pkg/proxy/reverse_proxy.go:109:67: too few values in struct initializer

Having the same issue, any ideas how to fix that?

[samerbahri98]

is this issue still relevant?