motiv-labs / janus

An API Gateway written in Go
https://hellofresh.gitbooks.io/janus
MIT License
2.79k stars 317 forks source link

Error while adding a plugin to the gateway #310

Closed kamiiiel closed 5 years ago

kamiiiel commented 6 years ago

I followed your documentation for adding a plugin (rate_limit) but unfortunately I get an error saying

{"error":"name is required;proxy.listen_path is required"}

So it seems the gateway consider that as a new APi and not a plugin for an existing API.

Btw, Thanks for your very nice app.

rafaeljesus commented 6 years ago

@elitegit thanks for opening the issue we'll gonna take a look at it

badaa commented 6 years ago

Same error occurred!

carolove commented 6 years ago

Same error occurred

s4nji commented 5 years ago

That is correct @elitegit; when sending a PUT request, the api definition will be replaced with the definition in the request body. The request would have worked if it were a PATCH request, however Janus doesn't handle PATCH requests, so it's a mistake in the documentation.