search

motiv-labs / janus

An API Gateway written in Go
https://hellofresh.gitbooks.io/janus
MIT License
2.79k stars 317 forks source link

Fixed forwarding timeouts duration unmarshalling #327

Closed vgarvardt closed 6 years ago

vgarvardt commented 6 years ago

What does this PR do?

Fixes issue found in https://github.com/hellofresh/janus/issues/320 - time.Duration from stdlib does not implement json.Unmarshaler interface.

codecov[bot] commented 6 years ago

Codecov Report

Merging #327 into master will increase coverage by 0.04%. The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   41.43%   41.47%   +0.04%     
==========================================
  Files          74       74              
  Lines        2474     2486      +12     
==========================================
+ Hits         1025     1031       +6     
- Misses       1387     1390       +3     
- Partials       62       65       +3
Impacted Files Coverage Δ
pkg/proxy/register.go 0% <0%> (ø) :arrow_up:
pkg/proxy/definition.go 80.48% <50%> (-12.62%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2cd4608...e21cde2. Read the comment docs.