search

motiv-labs / janus

An API Gateway written in Go
https://hellofresh.gitbooks.io/janus
MIT License
2.79k stars 317 forks source link

PT-1189 Fixed routers list comparison #329

Closed vgarvardt closed 6 years ago

vgarvardt commented 6 years ago

What does this PR do?

This PR fixes routes list comparison. The problem was in private proxy.Definition.middleware field - because of this I extracted the field into new proxy.RouterDefinition that is now used in all plugins, routers, etc.

codecov[bot] commented 6 years ago

Codecov Report

Merging #329 into master will increase coverage by 0.09%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   41.25%   41.35%   +0.09%     
==========================================
  Files          74       74              
  Lines        2499     2503       +4     
==========================================
+ Hits         1031     1035       +4     
  Misses       1403     1403              
  Partials       65       65
Impacted Files Coverage Δ
pkg/plugin/oauth2/setup.go 7.86% <0%> (ø) :arrow_up:
pkg/proxy/register.go 0% <0%> (ø) :arrow_up:
pkg/plugin/oauth2/loader.go 0% <0%> (ø) :arrow_up:
pkg/plugin/requesttransformer/setup.go 81.81% <100%> (ø) :arrow_up:
pkg/plugin/cb/middleware.go 93.54% <100%> (ø) :arrow_up:
pkg/plugin/compression/setup.go 100% <100%> (ø) :arrow_up:
pkg/plugin/responsetransformer/setup.go 81.81% <100%> (ø) :arrow_up:
pkg/plugin/bodylmt/setup.go 81.81% <100%> (ø) :arrow_up:
pkg/plugin/cors/setup.go 88.88% <100%> (ø) :arrow_up:
pkg/plugin/cb/setup.go 89.09% <100%> (ø) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40c5a4b...18c302b. Read the comment docs.