motiv-labs / janus

An API Gateway written in Go
https://hellofresh.gitbooks.io/janus
MIT License
2.79k stars 318 forks source link

PT-4186 Add trust_forward_headers configuration to rate-limit plugin #400

Closed s4nji closed 5 years ago

s4nji commented 5 years ago

Adds a configuration to Rate Limit Plugin trust_forward_headers.
Defaults to false.

Related

https://github.com/hellofresh/janus-dashboard/pull/314

codecov[bot] commented 5 years ago

Codecov Report

Merging #400 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   40.37%   40.37%           
=======================================
  Files          75       75           
  Lines        2635     2635           
=======================================
  Hits         1064     1064           
  Misses       1509     1509           
  Partials       62       62
Impacted Files Coverage Δ
pkg/plugin/rate/setup.go 51.92% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08cfd4a...5424eb3. Read the comment docs.

spetrashov commented 5 years ago

+1

Approved with Zappr Approved with Zappr

vgarvardt commented 5 years ago

👍

Approved with Zappr Approved with Zappr Approved with Zappr

aleksandrzhiliaev commented 5 years ago

+1

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr