motiv-labs / janus

An API Gateway written in Go
https://hellofresh.gitbooks.io/janus
MIT License
2.79k stars 318 forks source link

PT-5130 Make ochttp IsPublicEndpoint Configurable #416

Closed s4nji closed 5 years ago

s4nji commented 5 years ago

What does this PR do?

Allows IsPublicEndpoint boolean used in opencensus' ochttp plugin to be configured, in the case where Janus is not the entry point and incoming trace metadata is valuable.

Links and references

codecov[bot] commented 5 years ago

Codecov Report

Merging #416 into master will decrease coverage by 0.02%. The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
- Coverage   40.48%   40.46%   -0.03%     
==========================================
  Files          76       76              
  Lines        2655     2659       +4     
==========================================
+ Hits         1075     1076       +1     
- Misses       1517     1520       +3     
  Partials       63       63
Impacted Files Coverage Δ
pkg/proxy/register.go 0% <0%> (ø) :arrow_up:
pkg/proxy/register_options.go 0% <0%> (ø) :arrow_up:
pkg/config/specification.go 62.5% <100%> (+0.68%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2bb9bbd...5fb40ea. Read the comment docs.

vgarvardt commented 5 years ago

👍

Approved with Zappr Approved with Zappr Approved with Zappr

antonu17 commented 5 years ago

+1

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr