motiv-labs / janus

An API Gateway written in Go
https://hellofresh.gitbooks.io/janus
MIT License
2.79k stars 318 forks source link

split TRACING_JAEGER_SAMPLING_SERVER_URL to two env vars #428

Closed ashleyschuett closed 4 years ago

ashleyschuett commented 4 years ago

What does this PR do?

Split tracing URL to be able to be specified by two seperate envs, one for host, one for port

codecov[bot] commented 4 years ago

Codecov Report

Merging #428 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   40.46%   40.46%           
=======================================
  Files          76       76           
  Lines        2659     2659           
=======================================
  Hits         1076     1076           
  Misses       1520     1520           
  Partials       63       63
Impacted Files Coverage Δ
pkg/config/specification.go 62.5% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e877c17...e7bedb0. Read the comment docs.

aleksandrzhiliaev commented 4 years ago

+1

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr

spetrashov commented 4 years ago

+1

Approved with Zappr Approved with Zappr