motiv-labs / janus

An API Gateway written in Go
https://hellofresh.gitbooks.io/janus
MIT License
2.79k stars 318 forks source link

remove c-style (incorrect) switch handling #433

Closed loginakhil closed 4 years ago

loginakhil commented 4 years ago

What does this PR do?

We have some c-style code in go. This PR cleans up that.

vgarvardt commented 4 years ago

Thank you! Can this be covered with some tests just to make sure it will not be broken in the futere?

codecov[bot] commented 4 years ago

Codecov Report

Merging #433 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   45.14%   45.14%           
=======================================
  Files          77       77           
  Lines        2700     2700           
=======================================
  Hits         1219     1219           
  Misses       1402     1402           
  Partials       79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5485f1...4c558d8. Read the comment docs.

vgarvardt commented 4 years ago

👍

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr

isalopezt commented 4 years ago

+1

Approved with Zappr