vgarvardt commented 3 years ago

Right now it is not being used as travis allows static ports binding, but in GH Actions port is going to be dynamic, so it will be passed as env var to tests.

This PR adds dynamic port support to integration tests only, feature tests to be done.

One test marked as integration is simple unit test actually that does not require any deps, so build tag was removed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #442 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   40.46%   40.46%           
=======================================
  Files          76       76           
  Lines        2659     2659           
=======================================
  Hits         1076     1076           
  Misses       1520     1520           
  Partials       63       63

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b49992...edbbfa1. Read the comment docs.

aleksandrzhiliaev commented 3 years ago

+1

motiv-labs / janus

EES-574 Support dynamic port for deps in integration tests #442

Codecov Report