search

motiwari / BanditPAM

BanditPAM C++ implementation and Python package
MIT License
647 stars 38 forks source link

`cmake` `Debug` build gives erroneous answers #143

Closed motiwari closed 2 years ago

motiwari commented 2 years ago

This does not affect users since they should always be building in Release mode. However, it should be fixed.

The Debug build produces the same wrong results if given only 1 thread, and different wrong results if given multiple threads.

My guess is that this has something to do with floating point flags and has been observed elsewhere: https://stackoverflow.com/questions/141752/float-values-behaving-differently-across-the-release-and-debug-builds

motiwari commented 2 years ago

Resolved when initializing cache in main