Resolved testing failures in BanditPAM++

motiwari / BanditPAM

BanditPAM C++ implementation and Python package

MIT License

647 stars 38 forks source link

Resolved testing failures in BanditPAM++ #261

Closed lukeleeai closed 1 year ago

lukeleeai commented 1 year ago

Fixed the typo inside the new BanditPAM++ code
Fixed the testing failures: If BanditPAM and FastPAM1 produce different clustering results, we compare their losses. If BanditPAM's losses are smaller than FastPAM1, we ignore the mismatch.

height[bot] commented 1 year ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

lukeleeai commented 1 year ago

Closed the PR as the issues were solved better in v4.0.3_prelease

motiwari commented 1 year ago

@lukeleeai could you delete this branch if the commits are already in v4.0.3_prerelease?