motiwari / BanditPAM

BanditPAM C++ implementation and Python package
MIT License
647 stars 38 forks source link

R package: Make it possible to disable parallelization #266

Open mikldk opened 1 year ago

mikldk commented 1 year ago

Thanks for your contribution!

I am running an experiment where I want to parallelize in another dimension that using OpenMP in BanditPAM. Actually, it was caused by what I think is a race condition (maybe from multiple parallelizations), and I want to avoid that - an I am already parallelizing elsewhere.

I made an option to disable parallelization, although the package is compiled with OpenMP. Please see this pull request.

height[bot] commented 1 year ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

motiwari commented 1 year ago

Thank you for submitting a PR! @bnaras could you take a look?