motiz88 / react-dygraphs

A React wrapper for the dygraphs charting library.
MIT License
25 stars 20 forks source link

Dygraphs options status #2

Open motiz88 opened 8 years ago

motiz88 commented 8 years ago

This is a master issue tracking the implementation of appropriate React-ish wrappers for all dygraphs options.

The option names link to dygraph's documentation. Links to sub-issues, PRs, commits, etc. will be added after them as needed. Please discuss specific options in dedicated issues and not in this thread.

dmr commented 8 years ago

How is the status on this feature? Your commit looks like many of the options are mapped already. Are they?

motiz88 commented 8 years ago

Hi @dmr! They are practically all mapped, but untested - Meaning that I don't have first-hand knowledge that they work OK (or at all). I prefer to be careful here and not mark untested features as done.

Sadly, I have no active plans to add systematic tests at the moment, which would be the best way forward. But I'll definitely welcome such a PR.

pgruenbacher commented 8 years ago

dataWindow should be dateWindow?

Jet-Set-Willy commented 7 years ago

dataWindow should indeed be dateWindow

http://dygraphs.com/options.html#dateWindow