search

motla / vue-document-editor

:page_facing_up: Paper-sized WYSIWYG document editor for Vue apps
https://motla.github.io/vue-document-editor/
MIT License
313 stars 70 forks source link

Vue3 Support #10

Closed mrddter closed 3 years ago

mrddter commented 3 years ago

Hi. This component is very interesting.

I'm trying to use Demo.vue page in a blank Vue 3 project. But, I found some issues, probably in the conversion or something like that.

Is compatible or is there an example of how to use it?

motla commented 3 years ago

Hi! Thanks :) I've not tested it under Vue3 yet, but from what I've seen they removed the $nextTick method used here, here, and here. I believe this is the main reason for issues. I don't have much free time now. If you really need the Vue 3 compatibility and you feel able to debug it, don't hesitate to fork and submit a PR. Otherwise I can look at it but probably not before this September because I'm really full... sorry.

motla commented 3 years ago

Yeah ignore my previous comment about $nextTick, apparently it's still present in v3. Better check https://v3.vuejs.org/guide/migration/introduction.html#breaking-changes

mrddter commented 3 years ago

another point to consider is this https://v3.vuejs.org/guide/migration/array-refs.html#migration-strategy

mrddter commented 3 years ago

I'm testing this, perhaps is a good point to start 🚀

https://gist.github.com/mrddter/50196b948810b6b4f757ea3fa63099c9

mrddter commented 3 years ago

It's working well on vue3. Thanks 👍

motla commented 3 years ago

Thanks a lot for your help! I'm currently on vacation, I look at it when I'm home 😉

motla commented 3 years ago

@mrddter Library is now migrated to Vue3 from v2.0.0, thanks for your help.