search

motla / vue-file-toolbar-menu

:desktop_computer: UI file/toolbar menus for Vue apps
https://motla.github.io/vue-file-toolbar-menu
MIT License
150 stars 31 forks source link

Don't hardcode icons #12

Open ricardopolo opened 3 years ago

ricardopolo commented 3 years ago

In our project we have the package of icons from https://materialdesignicons.com/, the one used by Buefy and other big projects.

However this lib uses https://material.io/resources/icons/

This is suboptimal because we have two styles of icons. So my request would be:

  1. Be able to use other icons, like the ability to use a setting to select which package are you going to use. As example Buefy let you chose between Material Icons and Font Awesome
  2. Don't hardcode icons in the package. Currently, even If I managed to use other icons using HTML I would still have installed the icons I don't need because vue-file-toolbar-menu install them. Make them optional (this could apply to emojis too)
motla commented 3 years ago

Yes indeed it would be great. I can't spend much time on this unfortunately. Could you fork the project, tailor it to your needs and make a pull request?

ricardopolo commented 3 years ago

I dont have much time right now, but I will try do it it later. Thanks a lot!

Fanna1119 commented 2 years ago

Will see if I can make some changes for it to support iconify. https://iconify.design/ https://github.com/antfu/unplugin-icons I think this is the best step forward for really making it independent from a specific icon package