search

motleyagency / travis-ecs-deploy

Scripts for building, pushing and deploying a Dockerized app to Amazon ECS
MIT License
21 stars 3 forks source link

Deploying git tags #2

Open urbanslug opened 6 years ago

urbanslug commented 6 years ago

One can't deploy git tags because of the requirement for a var ECS_CLUSTER_BRANCH_NAME

There also isn't a way to just let one set CLUSTER because it's overriden here https://github.com/motleyagency/travis-ecs-deploy/blob/master/lib/ecs-deploy#L92 and set to false.

There should be a way for users to just pass --service-name and --cluster without the need to go through travis-ecs-deploy

petetnt commented 6 years ago

@urbanslug hi! Sorry for the late reply.

That sounds great! The ecs-deploy is vendored from https://github.com/silinternational/ecs-deploy/blob/develop/ecs-deploy (IIRC), so it might make sense to make the changes there first.

urbanslug commented 6 years ago

@petetnt Sorry for the late reply too.

Not sure if I'll have time to put into this because I am migrating services from ECS to kubernetes. Feel free to close the issue.

petetnt commented 6 years ago

@urbanslug no problem! I'll keep the issue open as it definitely something that would be really nice!