search

moto8916 / android_device_motorola_harpia

Device tree for Moto G Play (harpia)
12 stars 19 forks source link

Where should I report problems with Osprey builds? #7

Closed Peque closed 5 years ago

Peque commented 5 years ago

@sultanqasim @Alberto97 I built lineageos-15.1 based on your sources. Everything went well apparently, but the camera does not work. Where should I report this or reach out for help?

It seems the issues section in android_device_motorola_osprey is closed.

PS: I built it using this manifest. If you are interested I can transfer the repo to your organization, where I think it should be instead. :blush:

sultanqasim commented 5 years ago

https://github.com/moto8916/android_device_motorola_msm8916-common/blob/lineage-15.1/lineage.dependencies

You're missing android_external_bson in your manifest

sultanqasim commented 5 years ago

These repositories will be going official in a few weeks. The moto8916 organization is just my development staging organization shared with Alberto. The once official, no device manifest is needed, things are fetched automatically based on lineage.dependencies.

Peque commented 5 years ago

@sultanqasim Thanks for your help! :blush:

Adding android_external_bson in the manifest actually helps. Now the camera app is there and I can open it an make videos or panorama pictures. But I cannot take regular pictures... It says "Unknown error. Closing camera". Any ideas/suggestions?

sultanqasim commented 5 years ago

I don’t know what could cause that. I hadn’t heard any complaints about the camera on the build I posted to XDA last weekend. Clean flash maybe?

Peque commented 5 years ago

@sultanqasim Yeah, it was a clean flash. :woman_shrugging:

Peque commented 5 years ago

@sultanqasim By the way, I was using branch 15.1-new for vendor. Is that correct?

sultanqasim commented 5 years ago

Yes

Peque commented 5 years ago

@sultanqasim I am closing this issue. Thanks for your help!

Please tell me if you have any further advise/suggestions on how to proceed to try to fix/debug the camera issue (I do not even know where to start). :blush:

sultanqasim commented 5 years ago

Do you have boringssl-compat in your manifest? I think I forgot to put it in lineage.dependencies

Peque commented 5 years ago

@sultanqasim This one? If so, I do not have it in my manifest. Should I?

Could any SSL-related stuff be causing the camera misbehavior?

Alberto97 commented 5 years ago

Uhm, all these devices use M+ blobs, why do they need boringssl-compat? Also LD preloading it is a bad idea, in the past it messed up certain apps login (among them Facebook iirc). The "shim" way was born exactly for this reason

Akianonymus commented 5 years ago

boring ssl is not exactly for functionality of camera, it's for improvement in picture quality ig

sultanqasim commented 5 years ago

I need to look into why they were preloading it. As Aki says, it was claimed to improve image quality (maybe some conditional dlsym business?). I picked it but hate the LD_PRELOAD and want to kill it if at all possible. I’m guessing someone didn’t know what library to shim or was having issues making the shim work.

Peque commented 5 years ago

@sultanqasim I noticed @althafvly is adding android_device_qcom_common to his manifest with LineageOS 16. Would it make sense to try that in order to "fix" my camera issues? :joy:

I have seen it was removed recently from your repo.

althafvly commented 5 years ago

@Peque qcom common is no longer useful for us.. because dtbtool has moved to another repo.

Peque commented 5 years ago

@sultanqasim Is there an issue/place to track official LineageOS integration of this work? I would love to track progress and/or receive a notification on final integration.

@althafvly Do you plan to integrate your lineageos-16 work too? :blush: