search

mottosso / allzpark

Package-based application launcher for VFX and games production
https://allzpark.com
GNU Lesser General Public License v3.0
184 stars 38 forks source link

Fix dock hidden #118

Closed davidlatwe closed 3 years ago

davidlatwe commented 3 years ago

Problem 1

before

As you can see in the above GIF, the "Context" is not pop-up when I activate it.

It seems like it's not looking into the correct QTabBar and somehow the wrong QTabBar also has same named tab (might be the QTabBar inside the "Environment" tab which also has a tab named "Context").

When I print out the objectName of those bars :

https://github.com/mottosso/allzpark/blob/4bb9851578a7fd8a4a2760bce0bcc7ae78ea55a1/allzpark/view.py#L485

This is what I got :

['qt_tabwidget_tabbar', 'qt_tabwidget_tabbar', 'qt_tabwidget_tabbar', 'qt_tabwidget_tabbar', '', '', '', '']

And looks like those unnamed ('') tab bars are the right one to look up to, not sure what "qt_tabwidget_tabbar" are .. :S

Anyway, commit ba4351f resolved this problem.

Problem 2

The "Profiles" page can ignore the "Allow Multiple Docks" setting, which makes the header may have more than 1 active dock. And in previous implementation, the logic didn't try to bring "Profiles" page to up front, it just being ignored.

Commit 526f762 resolved this problem.

Fixed Result

after

mottosso commented 3 years ago

Looks great to me, feel free to merge at will

davidlatwe commented 3 years ago

Thanks !