search

mottosso / allzpark

Package-based application launcher for VFX and games production
https://allzpark.com
GNU Lesser General Public License v3.0
184 stars 38 forks source link

Fixes #131 #132

Closed evil-g closed 3 years ago

evil-g commented 3 years ago

This should fix the bug in #131. There's a handy iter_packages method on the rez package filter object, so just updated the existing utils to take a package_filter arg.

(Updated find_one too for posterity)

evil-g commented 3 years ago

Thanks @evil-g ! This looks good, just a few notes. 👍🏼 Maybe you could add a test case for this PR ? Or I'll add that later :)

sure no worries, i'll add a test as well and update the PR 👍

davidlatwe commented 3 years ago

Hi @evil-g, I may merging #129 later today, but that would produce conflict to this PR, so I'll resolve it and update this PR. If that woks for you ?

evil-g commented 3 years ago

hey @davidlatwe , sorry for the delay on that. i pushed the cleanup stuff and a first pass at the new unit test. but if you end up needing to change something else to merge #129 have at it :)

davidlatwe commented 3 years ago

Thanks for the quick move :D Appreciate it 👍🏼

davidlatwe commented 3 years ago

Well, the last running test seems to be stuck at job initializing, it holds there for over 10 mins. Let's call it all passed ! Thanks again @evil-g, will merge this later 🎉

davidlatwe commented 3 years ago

And 1.3.129 released ! p.s. @evil-g, I found that the commits you made seems not using the account that GitHub recognized so the contributor page doesn't have your name on it, and looks like there's nothing we could do now. But I tagged you in the release note though. :)

evil-g commented 3 years ago

And 1.3.129 released ! p.s. @evil-g, I found that the commits you made seems not using the account that GitHub recognized so the contributor page doesn't have your name on it, and looks like there's nothing we could do now. But I tagged you in the release note though. :)

oh yeah you're right...looks like it used the credentials for our internal gitlab. i'll update my git config for next time. thanks for pointing that out! :)