Closed wougzy closed 2 years ago
It's tricky for me to see which comments have been addressed; are you able to hit "Resolve Conversation" once you've addressed it?
I can't remember where we left this, I remember we had a conversation outside of this PR about it? :S What's missing here is a motivation for adding this amount of code, along with some examples of how to use it and what it is for.
Hate to close something with this amount of work. :( But it really does need reducing; it's hard to spot and test this many changes, and backwards compatibility is of utmost importance. A new (smaller) PR is welcomed!
hehe lot of adjustments ahead (: i'll comment all of these tonight. we're about to get a tight schedule at studio so i won't have too much time in the next days