moudey / Shell

Powerful context menu manager for Windows File Explorer
https://nilesoft.org
MIT License
2.9k stars 96 forks source link

recycle bin disabling bug.... #376

Closed VenusGirl closed 5 months ago

VenusGirl commented 6 months ago

After installing SHELL 1.9.10, there is a bug where the recycle bin is greyed out and not working.

Even after uninstallation, the recycle bin is not restored.

이미지 00x

RubicBG commented 6 months ago

https://github.com/moudey/Shell/issues/368

VenusGirl commented 6 months ago

// modify(type="recyclebin" where=window.is_desktop and this.id==id.empty_recycle_bin pos=1 sep vis=true) modify(type="recyclebin" where=window.is_desktop and this.name=="휴지통 비우기" pos=1 sep vis=true)

I replaced it with but it doesn't work.

RubicBG commented 6 months ago

try first: modify(type="*" find="휴지통 비우기" vis=true) if works change it to: modify(type="recyclebin" find="휴지통 비우기" pos=1 sep vis=true)

VenusGirl commented 6 months ago

Thank you. Both will activate the recyclebin.

Should I modify the script of Shell/config/ko/imports/modify.nss like this?

modify(type="*" find="휴지통 비우기" vis=true) Shell이미지 002

modify(type="recyclebin" find="휴지통 비우기" pos=1 sep vis=true) Shell이미지 003

RubicBG commented 6 months ago

type="*" - this is to remove any constraints, but it is not good syntax

regardless of whether the trash is empty the command will be available

the problem is in windows: https://answers.microsoft.com/en-us/windows/forum/all/recycle-bin-of-windows-10-not-working-proparly/175614ef-234d-47cf-a9b4-43e01810da43 hope this helps

CRiS-SVRS commented 6 months ago

type="*" - this is to remove any constraints, but it is not good syntax

regardless of whether the trash is empty the command will be available

the problem is in windows: https://answers.microsoft.com/en-us/windows/forum/all/recycle-bin-of-windows-10-not-working-proparly/175614ef-234d-47cf-a9b4-43e01810da43 hope this helps

in my case, shell v1.9.10 is the problem. uninstalled it, recycle bin works as expected. installed again v1.9, it works as expected. if i upgrade to v1.9.10 again, the problem returns.

edit: this happens on 2 physical machines with Win11 23H2, just tried.

akr-18 commented 6 months ago

Problem for me is also shell v1.9.10 (with latest Versions of Win10 and Win11). No problem with the previous versions. I've uninstalled shell and will wait until this issue is solved. Recycle bin works without shell v1.9.10.

moudey commented 6 months ago

@akr-18 Please test canary version https://nilesoft.org/download#canary

akr-18 commented 6 months ago

I've tried the canary version. still the same problem with the recycle bin.

VenusGirl commented 6 months ago

In my case, Win 11 stable, RP, Beta, Dev, Canary all didn't work

modify(type="*" find="휴지통 비우기" vis=true)

modify(type="recyclebin" find="휴지통 비우기" pos=1 sep vis=true)

After modifying to , it all worked normally.

dracp commented 6 months ago

@akr-18 Please test canary version https://nilesoft.org/download#canary

Shell Canary 1.9.11 / Windows 11 Pro 23H2 22631.2861

Recycle bin, full. "Empty Recycle Bin" option, disabled. It still doesn't work.

231214_Papelera de reciclaje_No funciona

SaiyajinK commented 6 months ago

In my case, Win 11 stable, RP, Beta, Dev, Canary all didn't work

modify(type="*" find="휴지통 비우기" vis=true)

modify(type="recyclebin" find="휴지통 비우기" pos=1 sep vis=true)

After modifying to , it all worked normally.

thx

modify(type="*" find="Vider la corbeille" vis=true)
modify(type="recyclebin" find="Vider la corbeille" pos=1 sep vis=true)

(this solves the main function but when the trash is emptied, you can empty it indefinitely because "Empty trash" always remains active even when it is empty) 👍🏻

RubicBG commented 6 months ago

can someone test it: https://nilesoft.org/download#canary changes: https://discord.com/channels/1106387012707168318/1112126326665650176/1190658405644374066

snuuuy commented 6 months ago

can someone test it: https://nilesoft.org/download#canary changes: https://discord.com/channels/1106387012707168318/1112126326665650176/1190658405644374066 image

Does not work Shell Canary 1.9.12 / Windows 11 Home 23H2 22631.2861

moudey commented 6 months ago

Please try Canary build 13 https://nilesoft.org/download#canary

CRiS-SVRS commented 6 months ago

Please try Canary build 13 https://nilesoft.org/download#canary

it now works. thank you

VenusGirl commented 5 months ago

Normal operation on Windows 11 Canary 12H3 26016.1012

Canary build 13 : https://nilesoft.org/download#canary

Before emptying the recyclebin Shell1

After emptying the recyclebin Shell2